Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added redhat ga repo #142

Merged
merged 2 commits into from
Jun 24, 2016
Merged

added redhat ga repo #142

merged 2 commits into from
Jun 24, 2016

Conversation

jasinner
Copy link
Member

No description provided.

@jasinner
Copy link
Member Author

This change adds the Red Hat GA Maven Repository to the list of repositories searchable in Victims Web. This will allow us to submit victims reports for Red Hat specific versions of artifacts.

@ashcrow ashcrow self-assigned this May 19, 2016
@@ -4,7 +4,7 @@ Flask-Admin>=1.0.7
Flask-Bcrypt
Flask-Bootstrap
Flask-Cache
Flask-Login>=0.1.1
Flask-Login==0.2.11
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you test with 0.2.x? Just want to make sure before hand 😄

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I tested the app, but did not thoroughly check the unit tests. If we use 0.3 or later of Flask Login we run into a breaking change: https://github.com/maxcountryman/flask-login/blob/master/CHANGES#L25-L26

@ashcrow
Copy link
Member

ashcrow commented Jun 2, 2016

One question. Otherwise looks good!

@jasinner
Copy link
Member Author

@ashcrow bump. Anything holding this up?

@ashcrow ashcrow merged commit 6adf89b into victims:master Jun 24, 2016
@jasinner
Copy link
Member Author

Thanks for pulling this change @ashcrow. Did you pull the change into the production codebase? I got an error like this when trying to submit a GAV via the web ui: #130

ashcrow pushed a commit that referenced this pull request Sep 29, 2016
* added redhat ga repo

* fixed bool change in flask-login and changed test adminuser password
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants